Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ruler configs in limits.go #11105

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Remove deprecated ruler configs in limits.go #11105

wants to merge 14 commits into from
+118 −566

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Nov 1, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 1, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Nov 2, 2023
@shantanualsi shantanualsi force-pushed the shantanu/remove-ruler-configs branch 2 times, most recently from 7292d47 to 6978a06 Compare November 8, 2023 07:31
@shantanualsi
Remove deprecated ruler_remote_write_url
fb1ae81
@shantanualsi
Remove deprecated ruler_remote_write_timeout
846c302
@shantanualsi
Remove deprecated ruler_remote_write_queue_max_shards and min_shards
c0a7584
@shantanualsi
Remove deprecated ruler_remote_write_queue_min_backoff, ruler_remote_…
6764c95 
…write_queue_max_backoff and ruler_remote_write_queue_retry_on_ratelimit
@shantanualsi
Remove deprecated ruler_remote_write_queue_batch_send_deadline and ru…
d573e20 
…ler_remote_write_queue_max_samples_per_send
@shantanualsi
Replace registry test with newFakeLimits
a40874d
@shantanualsi
Remove deprecated ruler_remote_write_relabel_configs, ruler_remote_wr…
54427dd 
…ite_queue_capacity and ruler_remote_write_sigv4_config
@shantanualsi
Format
d500ba3
@shantanualsi
Add documentation for ruler_remote_write_config
23a7a64
@shantanualsi
Merge branch 'main' into shantanu/remove-ruler-configs
95af9dc
@shantanualsi
Remove deprecated ruler_remote_write_headers
f68cffa
@shantanualsi shantanualsi force-pushed the shantanu/remove-ruler-configs branch from 6978a06 to f68cffa Compare November 16, 2023 10:10
@github-actions GitHub Actions
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@shantanualsi shantanualsi marked this pull request as ready for review November 16, 2023 10:14
@shantanualsi shantanualsi requested a review from a team as a code owner November 16, 2023 10:14
JStickler
JStickler approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Docs LGTM

@shantanualsi shantanualsi marked this pull request as draft April 10, 2024 06:55
@shantanualsi
Copy link
Contributor Author

We'll wait for an appropriate release in order to remove these configs. Needs more extensive testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shantanualsi @JStickler